Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): convert the sourcemap option to boolean (fix #13638) #13663

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

dd-jonas
Copy link
Contributor

@dd-jonas dd-jonas commented Jun 28, 2023

Description

Fix #13638

ee3b90a added 'inline' and 'hidden' as options to --sourcemap in the CLI and broke the behavior of booleans, i.e. true and false became strings. This resulted in --sourcemap false to still output sourcemaps.

Additional context

There's not really a clean way to convert 'true' and 'false' to a boolean. Feel free to suggest a different approach.
Also, I'm not sure if a test case should be added for this. It's my first contribution and didn't see tests related to CLI options.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy enabled auto-merge (squash) June 29, 2023 06:16
@bluwy bluwy merged commit d444bfe into vitejs:main Jun 29, 2023
@dd-jonas dd-jonas deleted the fix/cli-sourcemap-option-boolean branch June 29, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reached heap limit when building since v4.2
2 participants